Implement ICS-26 routing in {Validation, Execution}Context for ChanOpenTry
#347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 62.23% // Head: 61.01% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #347 +/- ##
==========================================
- Coverage 62.23% 61.01% -1.23%
==========================================
Files 124 124
Lines 14134 14498 +364
==========================================
+ Hits 8797 8846 +49
- Misses 5337 5652 +315
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
plafer
changed the title
{Validation, Execution}Context{Validation, Execution}Context for ChanOpenTry
There was a problem hiding this comment.
Thank you @plafer.
I'll probably revisit this PR after getting your response so I can absorb the design. Hope it doesn't cause you any delays.
Farhad-Shabani
pushed a commit
that referenced
this pull request
Sep 9, 2024
…nOpenTry` (#347) * Add `Router` trait for `ValidationContext` * Add `lookup_module_by_port()` to new Router * Add `lookup_module()` in new`Router` * simplify module_id * channel router WIP * validate step * add immutable route to router * add on_chan_open_try_validate() cb for ics20 * add on_chan_open_try_validate() to Module * finish validate for chan_open_try * chan_open_try_execute * execute core handler * Add on_chan_open_try_execute * ics-20: execute * execute: emit logs and events * no ModuleExtras for validate callback * chan_open_try execute * update error * take `channel_id` out of validate() * chan_open_try_execute * variable naming * clippy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards: #322
This implements ICS-26 routing in
{Validation, Execution}Contextfor theChanOpenTrymessage only. After this PR is merged, I'll implement the other messages in a similar manner.Note that we prioritize here a working implementation. We will improve it once a working version is shipped (see #325).
PR author checklist:
unclog.docs/).Reviewer checklist:
Files changedin the GitHub PR explorer.